[
https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387014#comment-16387014
]
ASF GitHub Bot commented on FLINK-8689:
---------------------------------------
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5555
@hequn8128 @fhueske Thanks for the feedback. I have updated the diff to
directly use DistinctAccumulator for filtering and modified the
`generateAggregation` API. Please kindly take another look when you have time.
I have resolved the issue of multiple layer dataview codegen.
In terms of reusing same `DataView` for multiple distinct aggregations
against the same field, I tried to incorporate but there are many assumptions
with single mapping between `AggregateFunction`s and `Accumulator`s that's hard
to deal with. I am planning to continue and improve on it in a separated JIRA,
what do you think?
> Add runtime support of distinct filter using MapView
> -----------------------------------------------------
>
> Key: FLINK-8689
> URL: https://issues.apache.org/jira/browse/FLINK-8689
> Project: Flink
> Issue Type: Sub-task
> Reporter: Rong Rong
> Assignee: Rong Rong
> Priority: Major
>
> This ticket should cover distinct aggregate function support to codegen for
> *AggregateCall*, where *isDistinct* fields is set to true.
> This can be verified using the following SQL, which is not currently
> producing correct results.
> {code:java}
> SELECT
> a,
> SUM(b) OVER (PARTITION BY a ORDER BY proctime ROWS BETWEEN 5 PRECEDING AND
> CURRENT ROW)
> FROM
> MyTable{code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
