Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5573#discussion_r172650031
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobAccumulatorsInfo.java
 ---
    @@ -33,19 +39,38 @@
     public class JobAccumulatorsInfo implements ResponseBody {
        public static final String FIELD_NAME_JOB_ACCUMULATORS = 
"job-accumulators";
        public static final String FIELD_NAME_USER_TASK_ACCUMULATORS = 
"user-task-accumulators";
    +   public static final String FIELD_NAME_SERIALIZED_USER_TASK_ACCUMULATORS 
= "serialized-user-task-accumulators";
     
        @JsonProperty(FIELD_NAME_JOB_ACCUMULATORS)
        private List<JobAccumulator> jobAccumulators;
     
        @JsonProperty(FIELD_NAME_USER_TASK_ACCUMULATORS)
        private List<UserTaskAccumulator> userAccumulators;
     
    +   @JsonProperty(FIELD_NAME_SERIALIZED_USER_TASK_ACCUMULATORS)
    +   @JsonSerialize(contentUsing = SerializedValueSerializer.class)
    +   private Map<String, SerializedValue<Object>> serializedUserAccumulators;
    +
        @JsonCreator
        public JobAccumulatorsInfo(
                        @JsonProperty(FIELD_NAME_JOB_ACCUMULATORS) 
List<JobAccumulator> jobAccumulators,
    -                   @JsonProperty(FIELD_NAME_USER_TASK_ACCUMULATORS) 
List<UserTaskAccumulator> userAccumulators) {
    +                   @JsonProperty(FIELD_NAME_USER_TASK_ACCUMULATORS) 
List<UserTaskAccumulator> userAccumulators,
    +                   @JsonDeserialize(contentUsing = 
SerializedValueDeserializer.class) 
@JsonProperty(FIELD_NAME_SERIALIZED_USER_TASK_ACCUMULATORS) Map<String, 
SerializedValue<Object>> serializedUserAccumulators) {
                this.jobAccumulators = 
Preconditions.checkNotNull(jobAccumulators);
                this.userAccumulators = 
Preconditions.checkNotNull(userAccumulators);
    +           this.serializedUserAccumulators = 
Preconditions.checkNotNull(serializedUserAccumulators);
    +   }
    +
    +   public List<JobAccumulator> getJobAccumulators() {
    --- End diff --
    
    missing `@JsonIgnore` annotations


---

Reply via email to