Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5573#discussion_r175734525
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java
---
@@ -542,6 +549,68 @@ public void testListJobs() throws Exception {
}
}
+ @Test
+ public void testGetAccumulators() throws Exception {
+ TestAccumulatorHandlers accumulatorHandlers = new
TestAccumulatorHandlers();
+ TestAccumulatorHandlers.TestAccumulatorHandler
accumulatorHandler = accumulatorHandlers.new TestAccumulatorHandler();
+
+ try (TestRestServerEndpoint ignored =
createRestServerEndpoint(accumulatorHandler)){
+
+ JobID id = new JobID();
+
+ {
+ Map<String, Object> accumulators =
restClusterClient.getAccumulators(id);
+ assertNotNull(accumulators);
+ assertEquals(1, accumulators.size());
+
+ assertEquals(true,
accumulators.containsKey("testKey"));
+ assertEquals("testValue",
accumulators.get("testKey").toString());
+ }
+ }
+ }
+
+ private class TestAccumulatorHandlers {
+
+ private class TestAccumulatorHandler extends
TestHandler<EmptyRequestBody, JobAccumulatorsInfo,
JobAccumulatorsMessageParameters> {
+
+ public TestAccumulatorHandler() {
+ super(JobAccumulatorsHeaders.getInstance());
+ }
+
+ @Override
+ protected CompletableFuture<JobAccumulatorsInfo>
handleRequest(@Nonnull HandlerRequest<EmptyRequestBody,
+ JobAccumulatorsMessageParameters> request,
@Nonnull DispatcherGateway gateway) throws RestHandlerException {
--- End diff --
parameter breaking not consistent
---
