Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5656#discussion_r172856770
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ZooKeeperHighAvailabilityITCase.java
 ---
    @@ -0,0 +1,333 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.test.checkpointing;
    +
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.api.common.functions.RichMapFunction;
    +import org.apache.flink.api.common.restartstrategy.RestartStrategies;
    +import org.apache.flink.api.common.state.ValueStateDescriptor;
    +import org.apache.flink.api.common.time.Deadline;
    +import org.apache.flink.api.common.time.Time;
    +import org.apache.flink.api.common.typeutils.base.StringSerializer;
    +import org.apache.flink.client.program.ClusterClient;
    +import org.apache.flink.configuration.ConfigConstants;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.configuration.HighAvailabilityOptions;
    +import org.apache.flink.configuration.TaskManagerOptions;
    +import org.apache.flink.core.testutils.OneShotLatch;
    +import org.apache.flink.runtime.concurrent.FutureUtils;
    +import org.apache.flink.runtime.jobgraph.JobGraph;
    +import org.apache.flink.runtime.jobgraph.JobStatus;
    +import org.apache.flink.runtime.state.FunctionInitializationContext;
    +import org.apache.flink.runtime.state.FunctionSnapshotContext;
    +import org.apache.flink.runtime.state.StateBackend;
    +import org.apache.flink.runtime.state.filesystem.FsStateBackend;
    +import org.apache.flink.runtime.testingUtils.TestingUtils;
    +import org.apache.flink.streaming.api.checkpoint.CheckpointedFunction;
    +import org.apache.flink.streaming.api.datastream.DataStreamSource;
    +import 
org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
    +import org.apache.flink.streaming.api.functions.source.SourceFunction;
    +import org.apache.flink.test.util.MiniClusterResource;
    +import org.apache.flink.util.Preconditions;
    +import org.apache.flink.util.TestLogger;
    +
    +import org.apache.curator.test.TestingServer;
    +import org.junit.AfterClass;
    +import org.junit.BeforeClass;
    +import org.junit.ClassRule;
    +import org.junit.Test;
    +import org.junit.rules.TemporaryFolder;
    +
    +import java.io.File;
    +import java.time.Duration;
    +import java.util.UUID;
    +import java.util.concurrent.CompletableFuture;
    +import java.util.concurrent.atomic.AtomicBoolean;
    +import java.util.concurrent.atomic.AtomicInteger;
    +
    +import static org.hamcrest.core.Is.is;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertNotNull;
    +import static org.junit.Assert.assertThat;
    +import static org.junit.Assert.assertTrue;
    +
    +/**
    + * Integration tests for {@link 
org.apache.flink.runtime.checkpoint.ZooKeeperCompletedCheckpointStore}.
    + */
    +public class ZooKeeperHighAvailabilityITCase extends TestLogger {
    +
    +   private static final Duration TEST_TIMEOUT = Duration.ofSeconds(10000L);
    +
    +   private static final int NUM_JMS = 1;
    +   private static final int NUM_TMS = 1;
    +   private static final int NUM_SLOTS_PER_TM = 1;
    +
    +   @ClassRule
    +   public static final TemporaryFolder temporaryFolder = new 
TemporaryFolder();
    +
    +   private static File haStorageDir;
    +
    +   private static TestingServer zkServer;
    +
    +   private static MiniClusterResource miniClusterResource;
    +
    +   private static OneShotLatch waitForCheckpointLatch = new OneShotLatch();
    +   private static OneShotLatch failInCheckpointLatch = new OneShotLatch();
    +   private static OneShotLatch successfulRestoreLatch = new OneShotLatch();
    +
    +   @BeforeClass
    +   public static void setup() throws Exception {
    +           zkServer = new TestingServer();
    +
    +           Configuration config = new Configuration();
    +           config.setInteger(ConfigConstants.LOCAL_NUMBER_JOB_MANAGER, 
NUM_JMS);
    +           config.setInteger(ConfigConstants.LOCAL_NUMBER_TASK_MANAGER, 
NUM_TMS);
    +           config.setInteger(TaskManagerOptions.NUM_TASK_SLOTS, 
NUM_SLOTS_PER_TM);
    +
    +           haStorageDir = temporaryFolder.newFolder();
    +
    +           config.setString(HighAvailabilityOptions.HA_STORAGE_PATH, 
haStorageDir.toString());
    +           config.setString(HighAvailabilityOptions.HA_CLUSTER_ID, 
UUID.randomUUID().toString());
    +           config.setString(HighAvailabilityOptions.HA_ZOOKEEPER_QUORUM, 
zkServer.getConnectString());
    +           config.setString(HighAvailabilityOptions.HA_MODE, "zookeeper");
    +
    +           // we have to manage this manually because we have to create 
the ZooKeeper server
    +           // ahead of this
    +           miniClusterResource = new MiniClusterResource(
    +                   new 
MiniClusterResource.MiniClusterResourceConfiguration(
    +                           config,
    +                           NUM_TMS,
    +                           NUM_SLOTS_PER_TM));
    +
    +           miniClusterResource.before();
    +   }
    +
    +   @AfterClass
    +   public static void tearDown() throws Exception {
    +           miniClusterResource.after();
    +
    +           zkServer.stop();
    +           zkServer.close();
    +   }
    +
    +   /**
    +    * Verify that we don't start a job from scratch if we cannot restore 
any of the
    +    * CompletedCheckpoints.
    +    *
    +    * <p>Synchronization for the different steps and things we want to 
observe happens via
    +    * latches in the test method and the methods of {@link 
CheckpointBlockingFunction}.
    +    *
    +    * <p>The test follows these steps:
    +    * <ol>
    +    *     <li>Start job and block on a latch until we have done some 
checkpoints
    +    *     <li>Block in the special function
    +    *     <li>Move away the contents of the ZooKeeper HA directory and 
make it non-writable
    --- End diff --
    
    you're never making the directory non-writable; you should also check that 
this is possible in the first place


---

Reply via email to