Github user StephanEwen commented on a diff in the pull request:
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/time/ ---
    @@ -0,0 +1,68 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.common.time;
    +import org.apache.flink.annotation.Internal;
    +import java.time.Duration;
    + * This class stores a deadline, as obtained via {@link #now()} or from 
{@link #plus(Duration)}.
    + */
    +public class Deadline {
    +   private final Duration time;
    --- End diff --
    I find this a bit confusing to use `Duration` here, because it really does 
not hold a duration, but an absolute point in time (in the future) evaluated 
against `System.nanoTime()`. I would simply use a `long deadlineNanos` here, 
which also makes the `isOverdue()` check (the most frequent one) cheaper.
    You can (and should) still use `Duration` for the arithmetic (adding time, 
etc) - simply convert to nanos.


Reply via email to