[ 
https://issues.apache.org/jira/browse/FLINK-8889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389658#comment-16389658
 ] 

ASF GitHub Bot commented on FLINK-8889:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5651
  
    I think this makes sense.
    
    +1


> Do not override config values in TestBaseUtils#startCluster
> -----------------------------------------------------------
>
>                 Key: FLINK-8889
>                 URL: https://issues.apache.org/jira/browse/FLINK-8889
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.5.0
>
>
> {{TestBaseUtils#startCluster}} is a utility method to easily start a cluster. 
> This method receives a Configuration to be used for the cluster, it does 
> however override several values regardless of whether they were set or not.
> It also sets various options to their default value which shouldn't be 
> necessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to