Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5645#discussion_r172907369
  
    --- Diff: 
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSerializer.java
 ---
    @@ -163,8 +224,19 @@ public T copy(T from, T reuse) {
     
        @Override
        public void copy(DataInputView source, DataOutputView target) throws 
IOException {
    -           T value = deserialize(source);
    -           serialize(value, target);
    +           if (CONCURRENT_ACCESS_CHECK) {
    +                   enterExclusiveThread();
    +           }
    +
    +           try {
    +                   T value = deserialize(source);
    --- End diff --
    
    I think we can simply remove the check around the `copy(DataInputView 
source, DataOutputView target)` because the respective critical parts 
(`serialize()` and `deserialize()`) are covered already.


---

Reply via email to