[
https://issues.apache.org/jira/browse/FLINK-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392735#comment-16392735
]
Kostas Kloudas commented on FLINK-8841:
---------------------------------------
Can someone comment on this issue?
I think it is important to keep a clean codebase as much as we can.
Keeping both serializers means that issues like
https://issues.apache.org/jira/browse/FLINK-8908 should be fixed on both of
them.
> Duplicate MapSerializer and HashMapSerializer.
> ----------------------------------------------
>
> Key: FLINK-8841
> URL: https://issues.apache.org/jira/browse/FLINK-8841
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing, Type Serialization System
> Affects Versions: 1.5.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Priority: Major
> Fix For: 1.5.0
>
>
> Currently there are two class MapSerializer and HashMapSerializer whose code
> is the same with the only difference being that one includes elements of type
> Map and the other HashMap.
> In addition, these two were merged on the same commit.
> I would like to remove the HashMapSerializer. I already created a branch
> without the HashMapSerialzer and nothing seems to be failing on Travis. The
> reasons why I hesitate to do it, is because I am not sure if this may create
> problems with Backwards Compatibility.
> [~xiaogang.sxg] could you elaborate a bit on why they were both added and if
> there is any danger in removing the HashMapSerializer?
> Also [~StephanEwen] and [[email protected]] it is worth having a
> look and if you are ok, I can remove the redundant serializer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
