Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r174338580
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/BackendRestorerProcedure.java
---
@@ -105,6 +105,8 @@ public T createAndRestore(@Nonnull List<? extends
Collection<S>> restoreOptions)
++alternativeIdx;
+ // IMPORTANT: please be careful when modifying the log
statements because they are used for validation in
+ // the automatic end-to-end tests. Those tests might
fail if they are not aligned with the log message!
if (restoreState.isEmpty()) {
LOG.debug("Creating {} with empty state.",
logDescription);
} else {
--- End diff --
nit: since this log's format is so special, maybe we can introduce a
`static final Sting LOG_FORMAT = "Creating {} with empty state."` for it, and
guard it by adding a unit test (feel free to ignore).
---
