[
https://issues.apache.org/jira/browse/FLINK-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405921#comment-16405921
]
ASF GitHub Bot commented on FLINK-8394:
---------------------------------------
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5725
[FLINK-8394] Lack of synchronization accessing expectedRecord in
ReceiverThread#shutdown
## What is the purpose of the change
* This pull request fixed a Lack of synchronization accessing
expectedRecord in ReceiverThread#shutdown.*
## Brief change log
- *Wrapped the `shutdown` method with keyword `synchronized`*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-8394
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5725.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5725
----
commit f4e4ac473cfde612e607e1fa418130f9eef6bcb9
Author: yanghua <yanghua1127@...>
Date: 2018-03-20T07:40:48Z
[FLINK-8394] Lack of synchronization accessing expectedRecord in
ReceiverThread#shutdown
----
> Lack of synchronization accessing expectedRecord in ReceiverThread#shutdown
> ---------------------------------------------------------------------------
>
> Key: FLINK-8394
> URL: https://issues.apache.org/jira/browse/FLINK-8394
> Project: Flink
> Issue Type: Test
> Components: Streaming
> Reporter: Ted Yu
> Assignee: vinoyang
> Priority: Minor
>
> {code}
> public void shutdown() {
> running = false;
> interrupt();
> expectedRecord.complete(0L);
> {code}
> Access to expectedRecord should be protected by synchronization, as done on
> other methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
