[
https://issues.apache.org/jira/browse/FLINK-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407739#comment-16407739
]
ASF GitHub Bot commented on FLINK-8394:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5725
Thank your trying to help improve Flink.
I think, however, this patch is not necessary. The method does not require
synchronization, it should be correct as it is.
> Lack of synchronization accessing expectedRecord in ReceiverThread#shutdown
> ---------------------------------------------------------------------------
>
> Key: FLINK-8394
> URL: https://issues.apache.org/jira/browse/FLINK-8394
> Project: Flink
> Issue Type: Test
> Components: Streaming
> Reporter: Ted Yu
> Assignee: vinoyang
> Priority: Minor
>
> {code}
> public void shutdown() {
> running = false;
> interrupt();
> expectedRecord.complete(0L);
> {code}
> Access to expectedRecord should be protected by synchronization, as done on
> other methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
