[
https://issues.apache.org/jira/browse/FLINK-9028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406078#comment-16406078
]
ASF GitHub Bot commented on FLINK-9028:
---------------------------------------
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5726#discussion_r175715354
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -476,6 +477,11 @@ public ApplicationId getClusterId(CommandLine
commandLine) {
public ClusterSpecification getClusterSpecification(CommandLine
commandLine) throws FlinkException {
final Configuration effectiveConfiguration =
applyCommandLineOptionsToConfiguration(commandLine);
+ // aim to check the parameters
+ ContaineredTaskManagerParameters.create(
+ effectiveConfiguration,
+
effectiveConfiguration.getInteger(TaskManagerOptions.TASK_MANAGER_HEAP_MEMORY),
1);
--- End diff --
👍 I will pull it out and add a test to guard it.
> flip6 should check config before starting cluster
> -------------------------------------------------
>
> Key: FLINK-9028
> URL: https://issues.apache.org/jira/browse/FLINK-9028
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Sihua Zhou
> Assignee: Sihua Zhou
> Priority: Major
> Fix For: 1.5.0
>
>
> In flip6, we should perform parameters checking before starting cluster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
