[
https://issues.apache.org/jira/browse/FLINK-9028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406277#comment-16406277
]
ASF GitHub Bot commented on FLINK-9028:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5726#discussion_r175752794
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -409,6 +411,12 @@ public void terminateCluster(ApplicationId
applicationId) throws FlinkException
}
}
+ private void checkConfig(ClusterSpecification clusterSpecification) {
+ long taskManagerMemorySize =
clusterSpecification.getTaskManagerMemoryMB();
+ long cutoff =
ResourceManagerRuntimeServices.calculateCutoffMB(flinkConfiguration,
taskManagerMemorySize);
+ TaskManagerServices.calculateHeapSizeMB(taskManagerMemorySize -
cutoff, flinkConfiguration);
--- End diff --
I somehow don't like that we calculate some value just in order to check
whether an unchecked exception is thrown. This should be imo more explicit. Or
at least it should get a comment explaining what's going on here.
> flip6 should check config before starting cluster
> -------------------------------------------------
>
> Key: FLINK-9028
> URL: https://issues.apache.org/jira/browse/FLINK-9028
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Sihua Zhou
> Assignee: Sihua Zhou
> Priority: Major
> Fix For: 1.5.0
>
>
> In flip6, we should perform parameters checking before starting cluster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
