Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5726#discussion_r175750782
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ---
    @@ -423,6 +431,9 @@ public void terminateCluster(ApplicationId 
applicationId) throws FlinkException
                        @Nullable JobGraph jobGraph,
                        boolean detached) throws Exception {
     
    +           // ------------------ Check if configuration is valid 
--------------------
    +           checkConfig(clusterSpecification);
    --- End diff --
    
    let's not abbreviate and name it `validateClusterSpecification`


---

Reply via email to