Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5726#discussion_r175752251
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ---
    @@ -409,6 +411,12 @@ public void terminateCluster(ApplicationId 
applicationId) throws FlinkException
                }
        }
     
    +   private void checkConfig(ClusterSpecification clusterSpecification) {
    --- End diff --
    
    This should throw a checked exception. Something like 
`InvalidConfigurationException` or so. But not just fail with an 
`IllegalStateException`.


---

Reply via email to