[
https://issues.apache.org/jira/browse/FLINK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407403#comment-16407403
]
Sihua Zhou commented on FLINK-9026:
-----------------------------------
Hi [~till.rohrmann] I'm a bit confused about "We should unregister Tasks from
the TaskManagerMetricGroup when they have reached a final state", I found the
{{Task}} will close the {{TaskMetricGroup}} they held when they reach a final
state, the {{TaskMetricGroup.close()}} will call
{{parent.removeTaskMetricGroup(executionId);}}, so the {{TaskMetricGroup}} will
be unregistered from the {{TaskManagerMetricGroup}} currently.
> Unregister finished tasks from TaskManagerMetricGroup and close it
> ------------------------------------------------------------------
>
> Key: FLINK-9026
> URL: https://issues.apache.org/jira/browse/FLINK-9026
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Till Rohrmann
> Assignee: Sihua Zhou
> Priority: Major
> Labels: flip-6
> Fix For: 1.5.0
>
>
> We should unregister {{Tasks}} from the {{TaskManagerMetricGroup}} when they
> have reached a final state. Moreover, we should close the
> {{TaskManagerMetricGroup}} either in the {{TaskExecutor#postStop}} method or
> let the caller do this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
