Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5580#discussion_r176658024
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
 ---
    @@ -306,18 +311,20 @@ public JobSubmissionResult submitJob(JobGraph 
jobGraph, ClassLoader classLoader)
                CompletableFuture<JobGraph> jobUploadFuture = 
portFuture.thenCombine(
                        getDispatcherAddress(),
                        (BlobServerPortResponseBody response, String 
dispatcherAddress) -> {
    -                           log.info("Uploading jar files.");
                                final int blobServerPort = response.port;
                                final InetSocketAddress address = new 
InetSocketAddress(dispatcherAddress, blobServerPort);
                                final List<PermanentBlobKey> keys;
                                try {
    -                                   keys = 
BlobClient.uploadJarFiles(address, flinkConfig, jobGraph.getJobID(), 
jobGraph.getUserJars());
    +                                   log.info("Uploading jar files.");
    +                                   keys = BlobClient.uploadFiles(address, 
flinkConfig, jobGraph.getJobID(), jobGraph.getUserJars());
    +                                   log.info("Uploading custom files.");
    --- End diff --
    
    don't think this should be logged if there's nothing to upload (which 
generally will be the default)


---

Reply via email to