Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5580#discussion_r176662757
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java 
---
    @@ -453,15 +460,51 @@ private void testGetFailsDuringStreaming(@Nullable 
final JobID jobId, BlobKey.Bl
        }
     
        /**
    -    * Tests the static {@link BlobClient#uploadJarFiles(InetSocketAddress, 
Configuration, JobID, List)} helper.
    +    * Tests the static {@link BlobClient#uploadFiles(InetSocketAddress, 
Configuration, JobID, List)} helper.
         */
        @Test
        public void testUploadJarFilesHelper() throws Exception {
                uploadJarFile(getBlobServer(), getBlobClientConfig());
        }
     
    +   @Test
    +   public void testDirectoryUploading() throws IOException {
    +           final File newFolder = temporaryFolder.newFolder();
    +           final File file1 = File.createTempFile("pre", "suff", 
newFolder);
    +           FileUtils.writeStringToFile(file1, "Test content");
    --- End diff --
    
    we have somewhere in a `FileUtils` a writeUtf8 method


---

Reply via email to