[
https://issues.apache.org/jira/browse/FLINK-9059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412021#comment-16412021
]
ASF GitHub Bot commented on FLINK-9059:
---------------------------------------
GitHub user suez1224 opened a pull request:
https://github.com/apache/flink/pull/5758
[FLINK-9059][Table API & SQL] add table type attribute; replace "sources"
with "tables" in environm…
## What is the purpose of the change
Add support for unified table source and sink declaration in environment
file definition.
This change prepares for FLINK-9049 (Create unified interfaces to configure
and instatiate TableSink) We want to get this change in before 1.5 so it wont
break the API in next flink release.
## Brief change log
- Refactor sql client environment file definition to replace "sources"
with "tables"
- Add "type" property to distinguish between table source and sink.
## Verifying this change
This change is already covered by existing tests, such as *(please describe
tests)*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: ( no )
- The runtime per-record code paths (performance sensitive): (no )
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/suez1224/flink FLINK-9059
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5758.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5758
----
commit 6da60ae23d83783137d44e282e06e16c947f0eb7
Author: Shuyi Chen <shuyi@...>
Date: 2018-03-23T06:00:00Z
add table type attribute; replace "sources" with "tables" in environment
file
----
> Add support for unified table source and sink declaration in environment file
> -----------------------------------------------------------------------------
>
> Key: FLINK-9059
> URL: https://issues.apache.org/jira/browse/FLINK-9059
> Project: Flink
> Issue Type: Task
> Components: Table API & SQL
> Reporter: Shuyi Chen
> Assignee: Shuyi Chen
> Priority: Major
> Fix For: 1.5.0
>
>
> 1) Add a common property called "tableType" with single value 'source'.
> 2) in yaml file, replace "sources" with "tables".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
