[jira] [Commented] (FLINK-9059) Add support for unified table source and sink declaration in environment file

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-9059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417836#comment-16417836
 ] 

ASF GitHub Bot commented on FLINK-9059:
---------------------------------------

Github user walterddr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5758#discussion_r177830071
  
    --- Diff: 
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
 ---
    @@ -102,10 +112,10 @@ public static Environment parse(String content) 
throws IOException {
        public static Environment merge(Environment env1, Environment env2) {
                final Environment mergedEnv = new Environment();
     
    -           // merge sources
    -           final Map<String, Source> sources = new 
HashMap<>(env1.getSources());
    -           mergedEnv.getSources().putAll(env2.getSources());
    -           mergedEnv.sources = sources;
    +           // merge tables
    +           final Map<String, TableDescriptor> sources = new 
HashMap<>(env1.getTables());
    --- End diff --
    
    `final Map<String, TableDescriptor> tables`


> Add support for unified table source and sink declaration in environment file
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-9059
>                 URL: https://issues.apache.org/jira/browse/FLINK-9059
>             Project: Flink
>          Issue Type: Task
>          Components: Table API &amp; SQL
>            Reporter: Shuyi Chen
>            Assignee: Shuyi Chen
>            Priority: Major
>             Fix For: 1.5.0
>
>
> 1) Add a common property called "type" with single value 'source'.
> 2) in yaml file, replace "sources" with "tables".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)