Github user yuqi1129 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5777#discussion_r177736130
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/TransientBlobCleanupTask.java
---
@@ -100,9 +102,15 @@ public void run() {
writeLock.lock();
try {
- if (!localFile.delete() &&
localFile.exists()) {
- log.warn("Failed to locally
delete blob " + localFile.getAbsolutePath());
- } else {
+ try {
--- End diff --
According to code before, entries will be deleted if no exception occur
whether file was deleted or not. As for you code logic, if We failed to delete
file, entries will stay in the Map.
---
