Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5782#discussion_r177803798
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphMetricsTest.java
 ---
    @@ -140,6 +140,9 @@ public void testExecutionGraphRestartTimeMetric() 
throws JobException, IOExcepti
     
                                assertTrue(currentRestartingTime >= 
previousRestartingTime);
                                previousRestartingTime = currentRestartingTime;
    +
    +                           // add some pause to let the 
currentRestartingTime increase
    +                           Thread.sleep(1L);
    --- End diff --
    
    move this to the start of the loop instead? (since you call 
`restartingTime.getValue()` right before the loop and at the start of the loop)


---

Reply via email to