Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5782#discussion_r178017114
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphMetricsTest.java
 ---
    @@ -140,6 +140,9 @@ public void testExecutionGraphRestartTimeMetric() 
throws JobException, IOExcepti
     
                                assertTrue(currentRestartingTime >= 
previousRestartingTime);
                                previousRestartingTime = currentRestartingTime;
    +
    +                           // add some pause to let the 
currentRestartingTime increase
    +                           Thread.sleep(1L);
    --- End diff --
    
    I think we have to keep it here, because otherwise the loop might finish so 
fast that we don't see an increase in `previousRestartingTime` because this 
value is effectively `System.currentTimeMillis - timestamps[RESTARTING]`.


---

Reply via email to