[ 
https://issues.apache.org/jira/browse/FLINK-9151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431959#comment-16431959
 ] 

ASF GitHub Bot commented on FLINK-9151:
---------------------------------------

GitHub user facboy opened a pull request:

    https://github.com/apache/flink/pull/5832

    [FLINK-9151] [Startup Shell Scripts] Export FLINK_CONF_DIR to job manager 
and task managers in standalone cluster mode (master)

    ## What is the purpose of the change
    
    This pull request makes the standalone cluster scripts pass FLINK_CONF_DIR 
to the launched job managers and task managers, rather than relying on the 
default config dir on the target host.
    
    ## Brief change log
    
    - Added export FLINK_CONF_DIR to `config.sh` and `start_cluser.sh`
    
    ## Verifying this change
    
    - I've only manually verified the change on 1.4.x.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/facboy/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5832.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5832
    
----
commit ec023753dadd1b4fda1b4ab23e9b0ce459f44667
Author: Christopher Ng <chris.ng@...>
Date:   2018-04-10T08:39:41Z

    FLINK-9151 Export FLINK_CONF_DIR to job manager and task managers in 
standalone cluster mode.

----


> standalone cluster scripts should pass FLINK_CONF_DIR to job manager and task 
> managers
> --------------------------------------------------------------------------------------
>
>                 Key: FLINK-9151
>                 URL: https://issues.apache.org/jira/browse/FLINK-9151
>             Project: Flink
>          Issue Type: Improvement
>          Components: Startup Shell Scripts
>    Affects Versions: 1.4.1
>            Reporter: Christopher Ng
>            Priority: Minor
>
> At the moment FLINK_CONF_DIR is not passed to the job manager and task 
> manager when they are started over SSH.  This means that if the user has a 
> locally set FLINK_CONF_DIR that is not configured by their login shell, it is 
> not used by the launched job manager and task manager which can result in 
> silently failing to launch if there are errors due to Flink not using the 
> correct config dir.
> One particular inconsistency is that a TaskManagers may be launched locally 
> (without ssh) on localhost, but JobManagers are always launched over ssh.  In 
> my particular case this meant that the TaskManager launched but the 
> JobManager silently failed to launch.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to