[
https://issues.apache.org/jira/browse/FLINK-9153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432138#comment-16432138
]
ASF GitHub Bot commented on FLINK-9153:
---------------------------------------
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5834
[FLINK-9153] TaskManagerRunner should support rpc port range
## What is the purpose of the change
*This pull request makes `TaskManagerRunner` (FLIP-6) supports rpc port
range*
## Brief change log
- *Fixed a config item reading bug and let taskmanager runner support rpc
port range *
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-9153
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5834
----
commit 212884207844d9485eb63e5e1ba32118e9fa1567
Author: yanghua <yanghua1127@...>
Date: 2018-04-10T11:52:16Z
[FLINK-9153] TaskManagerRunner should support rpc port range
----
> TaskManagerRunner should support rpc port range
> -----------------------------------------------
>
> Key: FLINK-9153
> URL: https://issues.apache.org/jira/browse/FLINK-9153
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
> Affects Versions: 1.4.0, 1.5.0
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
> Fix For: 1.5.0
>
>
> TaskManagerRunner current just support one specific port :
> {code:java}
> final int rpcPort =
> configuration.getInteger(ConfigConstants.TASK_MANAGER_IPC_PORT_KEY, 0);
> {code}
> It should support port range as the document described :
> https://ci.apache.org/projects/flink/flink-docs-master/ops/config.html#taskmanager-rpc-port
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
