[
https://issues.apache.org/jira/browse/FLINK-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432865#comment-16432865
]
ASF GitHub Bot commented on FLINK-9152:
---------------------------------------
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5830#discussion_r180541190
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/co/KeyedBroadcastProcessFunction.java
---
@@ -89,11 +89,11 @@
* query the current processing/event time, and also query and update
the internal
* {@link org.apache.flink.api.common.state.BroadcastState broadcast
state}. In addition, it
* can register a {@link KeyedStateFunction function} to be applied to
all keyed states on
- * the local partition. These can be done through the provided {@link
Context}.
+ * the local partition. These can be done through the provided {@link
BaseBroadcastProcessFunction.Context}.
* The context is only valid during the invocation of this method, do
not store it.
*
* @param value The stream element.
- * @param ctx A {@link Context} that allows querying the timestamp of
the element,
+ * @param ctx A {@link BaseBroadcastProcessFunction.Context} that
allows querying the timestamp of the element,
--- End diff --
Remove the `BaseBroadcastProcessFunction`.
> Harmonize BroadcastProcessFunction Context names
> ------------------------------------------------
>
> Key: FLINK-9152
> URL: https://issues.apache.org/jira/browse/FLINK-9152
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Affects Versions: 1.5.0
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Blocker
> Fix For: 1.5.0
>
>
> Currently, the {{Context}} on {{KeyedBroadcastProcessFunction}} is called
> {{KeyedContext}}, which is different from the name of the context on
> {{BroadcastProcessFunction}}. This leads to the strange combination of
> {code:java}
> public abstract void processBroadcastElement(final IN2 value, final
> KeyedContext ctx, final Collector<OUT> out) throws Exception;
> {code}
> i.e. you're processing a broadcast element but the context is called a
> "keyed" context.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
