[ 
https://issues.apache.org/jira/browse/FLINK-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432864#comment-16432864
 ] 

ASF GitHub Bot commented on FLINK-9152:
---------------------------------------

Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5830#discussion_r180538022
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperator.java
 ---
    @@ -33,6 +33,8 @@
     import org.apache.flink.streaming.api.TimeDomain;
     import org.apache.flink.streaming.api.TimerService;
     import 
org.apache.flink.streaming.api.functions.co.KeyedBroadcastProcessFunction;
    +import 
org.apache.flink.streaming.api.functions.co.KeyedBroadcastProcessFunction.Context;
    --- End diff --
    
    Unused import.


> Harmonize BroadcastProcessFunction Context names
> ------------------------------------------------
>
>                 Key: FLINK-9152
>                 URL: https://issues.apache.org/jira/browse/FLINK-9152
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.5.0
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> Currently, the {{Context}} on {{KeyedBroadcastProcessFunction}} is called 
> {{KeyedContext}}, which is different from the name of the context onĀ 
> {{BroadcastProcessFunction}}. This leads to the strange combination of
> {code:java}
> public abstract void processBroadcastElement(final IN2 value, final 
> KeyedContext ctx, final Collector<OUT> out) throws Exception;
> {code}
> i.e. you're processing a broadcast element but the context is called a 
> "keyed" context.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to