ASF GitHub Bot commented on FLINK-2435:

GitHub user DmitryKober opened a pull request:


    [FLINK-2435] Extending CsvReader capabilities: it is now possible to let 
user-defined classes be presented in csv fields.

    *Thank you very much for contributing to Apache Flink - we are happy that 
you want to help us improve Flink. To help the community review your 
contribution in the best possible way, please go through the checklist below, 
which will get the contribution into a shape in which it can be best reviewed.*
    *Please understand that we do not do this to make contributions to Flink a 
hassle. In order to uphold a high standard of quality for code contributions, 
while at the same time managing a large number of contributions, we need 
contributors to prepare the contributions well, and give reviewers enough 
contextual information for the review. Please also understand that 
contributions that do not follow this guide will take longer to review and thus 
typically be picked up with lower priority by the community.*
    ## Contribution Checklist
      - Make sure that the pull request corresponds to a [JIRA 
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are 
made for typos in JavaDoc or documentation files, which need no JIRA issue.
      - Name the pull request in the form "[FLINK-XXXX] [component] Title of 
the pull request", where *FLINK-XXXX* should be replaced by the actual issue 
number. Skip *component* if you are unsure about which is the best component.
      Typo fixes that have no associated JIRA issue should be named following 
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or 
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
      - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
      - Make sure that the change passes the automated tests, i.e., `mvn clean 
verify` passes. You can set up Travis CI to do that following [this 
      - Each pull request should address only one issue, not mix up code from 
multiple issues.
      - Each commit in the pull request has a meaningful commit message 
(including the JIRA id)
      - Once all items of the checklist are addressed, remove the above text 
and this checklist, leaving only the filled out template below.
    **(The sections below can be removed for hotfixes of typos)**
    ## What is the purpose of the change
    *(For example: This pull request makes task deployment go through the blob 
server, rather than through RPC. That way we avoid re-transferring them on each 
deployment (during recovery).)*
    ## Brief change log
    *(for example:)*
      - *The TaskInfo is stored in the blob store on job creation time as a 
persistent artifact*
      - *Deployments RPC transmits only the blob storage reference*
      - *TaskManagers retrieve the TaskInfo from the blob cache*
    ## Verifying this change
    *(Please pick either of the following options)*
    This change is a trivial rework / code cleanup without any test coverage.
    This change is already covered by existing tests, such as *(please describe 
    This change added tests and can be verified as follows:
      - *Added integration tests for end-to-end deployment with large payloads 
      - *Extended integration test for recovery after master (JobManager) 
      - *Added test that validates that TaskInfo is transferred only once 
across recoveries*
      - *Manually verified the change by running a 4 node cluser with 2 
JobManagers and 4 TaskManagers, a stateful streaming program, and killing one 
JobManager and two TaskManagers during the execution, verifying that recovery 
happens correctly.*
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (yes / no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / no)
      - The serializers: (yes / no / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / no / 
don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
      - The S3 file system connector: (yes / no / don't know)
    ## Documentation
      - Does this pull request introduce a new feature? (yes / no)
      - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / not documented)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DmitryKober/flink flink-2435

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5835
commit 9dbb505b9b6164e09710ca84c112d3e31a02e1d8
Author: Dmitrii_Kober <dmitrii_kober@...>
Date:   2018-03-27T17:40:12Z

    FLINK-2435: Initial Upload

commit 010d4db226eb824076ade5139afcf5dc6cd345c7
Author: Dmitry-Kober <dmitry.kober.main@...>
Date:   2018-03-28T17:14:51Z

    Got rid of CustomTypeInfoRegister

commit 16be64a7c25877db7a39eb751f69b3de3e4ca7ba
Author: Dmitrii_Kober <dmitrii_kober@...>
Date:   2018-03-30T14:45:31Z

    FLINK-2435: custom parser registration fix

commit f2c71775b57fc588d6174636ade49257e6c116a3
Author: Dmitrii_Kober <dmitrii_kober@...>
Date:   2018-04-02T11:08:18Z

    FLINK-2435: adjustment made for the custom FieldParser registration

commit 9df8b56e3960ee9a5e593610e14c6387a96ece01
Author: Dmitrii_Kober <dmitrii_kober@...>
Date:   2018-04-02T11:16:18Z

    FLINK-2435: failing tests are fixed

commit 085a0112d7c22a6cce106e65d06c6746dac32640
Author: Dmitrii_Kober <dmitrii_kober@...>
Date:   2018-04-03T12:36:28Z

    FLINK-2435: preciseTypes() method is added to CsvReader to handle Java 

commit 8a58a8a1b442f835091e0613ec535c9d2353665f
Author: Dmitrii_Kniazev <dmitrii_kniazev@...>
Date:   2018-04-03T13:40:20Z

    [FLINK-2435] [EPMOSBD-179] CsvReader row type support;
    added row type support for  CsvReader;

commit 98c9d3e49cf960269cf16a4eb810d25f6871a370
Author: Dmitrii_Kniazev <dmitrii_kniazev@...>
Date:   2018-04-04T10:01:20Z

    [FLINK-2435] [EPMOSBD-179] fixed bug with selected fields;
    added method for preparing selectedFields from includedMask;
    added included fields check (number of included fields must be equal to 
row's arity now);
    added test for row type;

commit 894a9699023220749982a9ea66ddca60b46e2f82
Author: Dmitrii_Kniazev <dmitrii_kniazev@...>
Date:   2018-04-04T10:06:12Z

    Merge branch 'flink-2435' into EPMOSBD-179
    # Conflicts:
    #   flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java

commit b708ce322ac429cb9232c6373dd1409c44d8402d
Author: Dmitrii_Kniazev <dmitrii_kniazev@...>
Date:   2018-04-04T10:11:03Z

    [FLINK-2435] [EPMOSBD-179] fixed merge conflicts;

commit 36174ea8138840a56eba938537d87fd556cff9ca
Author: Dmitrii_Kober <dmitrii_kober@...>
Date:   2018-04-04T16:17:13Z

    FLINK-2435: Unit tests are enhanced for CsvReader

commit a39a66a5c3f95e277bc7b65024ea8ab862e8a021
Author: Dmitrii_Kober <dmitrii_kober@...>
Date:   2018-04-04T17:54:47Z

    FLINK-2435: Integration tests for CsvReader are added

commit d227f94c9f2d216c9c9e074c3c9d6abb67668f6c
Author: Dmitrii_Kniazev <dmitrii_kniazev@...>
Date:   2018-04-05T08:14:43Z

    Merge branch 'flink-2435' into EPMOSBD-179
    # Conflicts:
    #   flink-tests/src/test/java/org/apache/flink/test/io/CsvReaderITCase.java

commit d5bb5278c83058ef3004b40b506e9f9b55d6209a
Author: Dmitrii_Kniazev <dmitrii_kniazev@...>
Date:   2018-04-05T09:14:17Z

    [FLINK-2435] [EPMOSBD-179] added Java Generics support for row type;
    - preciseRowType() method was added to CsvReader to handle Java Generics;
    - added tests;

commit f3e66fc9b2c105f55c0ffabd91f1a6fb322e3896
Author: Dmitrii_Kniazev <dmitrii_kniazev@...>
Date:   2018-04-05T11:31:02Z

    [FLINK-2435] [EPMOSBD-179] fixed row type API;
    - preciseRowType() method was made private;
    - fixed tests;

commit d296d29db438e0a4ab42058942ff5b343f150c51
Author: Vladimir Sergeev <vladimir_sergeev1@...>
Date:   2018-04-05T12:36:45Z

    EPMOSBD-180 - added tests for pojoType usage in csvreader

commit f087d0419c1ad9b99c5064f53e760e6af1d58e81
Author: Dmitrii_Kniazev <dmitrii_kniazev@...>
Date:   2018-04-06T09:51:25Z

    [FLINK-2435] [EPMOSBD-179] added more tests and javadoc

commit ca8ae5c72e5f95b169ca9fbf9cac0a15f3d4e014
Author: Vladimir Sergeev <vladimir_sergeev1@...>
Date:   2018-04-06T17:44:39Z

    EPMOSBD-180 - added precisePojoType for csv reader. Tests updated

commit 44900ef074907f522221698ea2f2381c6a55c8aa
Author: DmitryKober <dmitry.kober@...>
Date:   2018-04-09T08:12:38Z

    Merge pull request #3 from DmitryKober/EPMOSBD-179
    [EPMOSBD-179] CsvReader Row Type support

commit 726616ecb9cf87c33f8d3b47d5c2b31fda774b13
Author: DmitryKober <dmitry.kober@...>
Date:   2018-04-09T08:13:41Z

    Merge pull request #2 from DmitryKober/EPMOSBD-180
    Epmosbd 180 - tests for pojoType

commit 21c347db25c850e7b2e6cee98609d9c42a719bf5
Author: Dmitrii_Kober <dmitrii_kober@...>
Date:   2018-04-09T11:40:38Z

    FLINK-2435: The majority of CSVReader integration tests are turned into 
Given-When-Then style

commit 96ca68224b197f980a4bccf3678f24591fd6e81f
Author: Dmitrii_Kober <dmitrii_kober@...>
Date:   2018-04-09T14:31:25Z

    FLINK-2435: Refactoring of CsvReader tests

commit 1875c4dab767bd95e7d415deb0b339b34110ba27
Author: Dmitrii_Kober <dmitrii_kober@...>
Date:   2018-04-09T14:40:56Z

    FLINK-2435: Refactoring of CsvReader tests

commit e53159ea671fe7926753ba26bcf0e996d1d262b1
Author: Dmitrii_Kober <dmitrii_kober@...>
Date:   2018-04-09T16:54:41Z

    FLINK-2435: Added integration tests for Java Generics aware user-defined 

commit 88f7772eb609656ddfbc25ca7ebea3ec4fef1d9d
Author: Vladimir Sergeev <vladimir_sergeev1@...>
Date:   2018-04-09T17:25:53Z

    EPMOSBD-180 - fixed issue with throwing NoSuchField Exception

commit b3ff0e661884ff4a00a3a3a468528e56addc4d67
Author: DmitryKober <dmitry.kober@...>
Date:   2018-04-10T07:48:53Z

    Merge pull request #4 from DmitryKober/EPMOSBD-180
    Epmosbd 180

commit d75f3f62f91f5a2959b647478d4439259d9863d4
Author: Dmitrii_Kniazev <dmitrii_kniazev@...>
Date:   2018-04-10T08:50:54Z

    [FLINK-2435] [EPMOSBD-179] added support of generified types;
    - method preciseRowType() is open now;
    - added javaDoc to preciseRowType() method;
    - added test for generified types;

commit aa65ce7c310b97bf520897b9f111d4476b89cd1c
Author: Vladimir Sergeev <vladimir_sergeev1@...>
Date:   2018-04-10T10:10:43Z

    FLINK-2435: added missing license header

commit 822657be2378b36f9d7bb3a5914997766c9cf118
Author: Dmitrii_Kniazev <dmitrii_kniazev@...>
Date:   2018-04-10T12:22:29Z

    Merge branch 'flink-2435' into EPMOSBD-179

commit 2912e5e274ff34df74f19165b8bcce734a986468
Author: Dmitrii_Kober <dmitrii_kober@...>
Date:   2018-04-10T12:30:58Z

    FLINK-2435: Adjusting Maven dependencies and comments


> Add support for custom CSV field parsers
> ----------------------------------------
>                 Key: FLINK-2435
>                 URL: https://issues.apache.org/jira/browse/FLINK-2435
>             Project: Flink
>          Issue Type: New Feature
>          Components: DataSet API
>    Affects Versions: 0.10.0
>            Reporter: Fabian Hueske
>            Assignee: Dmitrii Kober
>            Priority: Minor
>             Fix For: 1.0.0
> The {{CSVInputFormats}} have only {{FieldParsers}} for Java's primitive types 
> (byte, short, int, long, float, double, boolean, String).
> It would be good to add support for CSV field parsers for custom data types 
> which can be registered in a {{CSVReader}}. 
> We could offer two interfaces for field parsers.
> 1. The regular low-level {{FieldParser}} which operates on a byte array and 
> offsets.
> 2. A {{StringFieldParser}} which operates on a String that has been extracted 
> by a {{StringParser}} before. This interface will be easier to implement but 
> less efficient.

This message was sent by Atlassian JIRA

Reply via email to