GitHub user zentol opened a pull request:

    [FLINK-9156][REST][CLI] Update --jobmanager option logic for REST client

    ## What is the purpose of the change
    With this PR the `--jobmanager` option is properly respected by the 
`RestClusterClient`. The problem was that the existing code was only setting 
`JobManagerOptions.ADDRESS` and `JobManagerOptions.PORT`, but not the 
corresponding `RestOptions` that are used for all REST API calls. The 
`RestOptions` are accessed 
in`HighAvailabilityServicesUtils#createHighAvailabilityServices` to create the 
webmonitor URL that is used by the client.
    ## Brief change log
    * set appropriate RestOptions in `CliFrontend#setJobManagerAddressInConfig`
    * add test
    ## Verifying this change
    * run `RestClusterClientTest#testRESTManualConfigurationOverride`
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    ## Documentation
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)

You can merge this pull request into a Git repository by running:

    $ git pull 9156

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5838
commit 661c313fcb4b5f4b4d5b31d52b4d9637a081035e
Author: zentol <chesnay@...>
Date:   2018-04-11T10:48:51Z

    [FLINK-9156][REST][CLI] Update --jobmanager option logic for REST client



Reply via email to