Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5838#discussion_r181141707
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java
---
@@ -677,6 +682,37 @@ public void testGetAccumulators() throws Exception {
}
}
+ /**
+ * Tests that command line options override the configuration settings.
+ */
+ @Test
+ public void testRESTManualConfigurationOverride() throws Exception {
+ final String localhost = "localhost";
--- End diff --
Maybe `configuredHostname`, to be consistent with `manualHostname`.
`localhost` is an arbitrary value, and should not be the name of the variable.
---
