[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439432#comment-16439432
]
ASF GitHub Bot commented on FLINK-9179:
---------------------------------------
GitHub user lamber-ken opened a pull request:
https://github.com/apache/flink/pull/5855
[FLINK-9179] add prometheus pushgateway reporter
## What is the purpose of the change
This pull request makes flink system can send metrics to prometheus via
pushgateway. when using `yarn-cluster` model, it's useful.
## Brief change log
- Add prometheus pushgateway repoter
- Restructure the code of the promethues reporter part
## Verifying this change
This change is already covered by existing tests. [prometheus
test](https://github.com/apache/flink/tree/master/flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus)
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lamber-ken/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5855.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5855
----
commit 7332c6df905f3f9d56615618fb000d2449109f3f
Author: xl38154 <!@...>
Date: 2018-04-16T12:58:44Z
add prometheus pushgateway reporter
----
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -----------------------------------------------------
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: mingleizhang
> Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
