[ 
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439443#comment-16439443
 ] 

ASF GitHub Bot commented on FLINK-9179:
---------------------------------------

Github user zhangminglei commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5856#discussion_r181733675
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/WebOptions.java ---
    @@ -38,7 +38,10 @@
     
        /**
         * The port for the runtime monitor web-frontend server.
    +    *
    +    * @deprecated Use {@link RestOptions#PORT} instead
         */
    --- End diff --
    
    FLINK-9180 rename it to RestOptions#PORT. 


> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -----------------------------------------------------
>
>                 Key: FLINK-9179
>                 URL: https://issues.apache.org/jira/browse/FLINK-9179
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration, REST, Webfrontend
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: mingleizhang
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the 
> WebUI listens on. With the rework of the REST API we added a new 
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST 
> API listens on.
> Effectively these 2 options control the same thing, with the rest option 
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to 
> {{RestOptions.REST_PORT}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to