[ 
https://issues.apache.org/jira/browse/FLINK-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447119#comment-16447119
 ] 

ASF GitHub Bot commented on FLINK-9188:
---------------------------------------

GitHub user tweise opened a pull request:

    https://github.com/apache/flink/pull/5889

    [FLINK-9188] [kinesis] Generic mechanism to set ClientConfiguration 
properties.

    ## What is the purpose of the change
    
    This pull request enables setting properties on the AWS ClientConfiguration 
from user supplied properties with a specific prefix.
    
    ## Brief change log
    - use Jackson to set properties in a generic way so that we don't need to 
assume knowledge of the AWS properties in the Flink connector code.
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    Added test to verify the configuration mechanism.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tweise/flink FLINK-9188.ConfigureKinesisClient

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5889.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5889
    
----
commit b65ffd5a3fd72478c7cfdaff17b4199febaa7650
Author: Thomas Weise <thw@...>
Date:   2018-04-17T05:01:52Z

    [FLINK-9188] [kinesis] Generic mechanism to set ClientConfiguration 
properties.

----


> Provide a mechanism to configure AmazonKinesisClient in FlinkKinesisConsumer
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-9188
>                 URL: https://issues.apache.org/jira/browse/FLINK-9188
>             Project: Flink
>          Issue Type: Task
>          Components: Kinesis Connector
>            Reporter: Thomas Weise
>            Priority: Major
>
> It should be possible to control the ClientConfiguration to set socket 
> timeout and other properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to