[ 
https://issues.apache.org/jira/browse/FLINK-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451811#comment-16451811
 ] 

ASF GitHub Bot commented on FLINK-9188:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5889#discussion_r183966110
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
 ---
    @@ -186,7 +186,10 @@ protected KinesisProxy(Properties configProps) {
         * @return
         */
        protected AmazonKinesis createKinesisClient(Properties configProps) {
    -           return AWSUtil.createKinesisClient(configProps, new 
ClientConfigurationFactory().getConfig());
    +
    +           ClientConfiguration awsClientConfig = new 
ClientConfigurationFactory().getConfig();
    +           AWSUtil.setAwsClientConfigProperties(awsClientConfig, 
configProps);
    +           return AWSUtil.createKinesisClient(configProps, 
awsClientConfig);
    --- End diff --
    
    Currently, the explicit Flink-defined keys in `AWSConfigConstants` will 
override whatever is set via the generic mechanism, correct?


> Provide a mechanism to configure AmazonKinesisClient in FlinkKinesisConsumer
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-9188
>                 URL: https://issues.apache.org/jira/browse/FLINK-9188
>             Project: Flink
>          Issue Type: Task
>          Components: Kinesis Connector
>            Reporter: Thomas Weise
>            Priority: Major
>
> It should be possible to control the ClientConfiguration to set socket 
> timeout and other properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to