[
https://issues.apache.org/jira/browse/FLINK-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447540#comment-16447540
]
ASF GitHub Bot commented on FLINK-9185:
---------------------------------------
GitHub user StephenJeson opened a pull request:
https://github.com/apache/flink/pull/5894
[FLINK-9185] [runtime] Fix potential null dereference in PrioritizedO…
## What is the purpose of the change
Fix potential null dereference in
PrioritizedOperatorSubtaskState#resolvePrioritizedAlternatives
## Brief change log
- Add null check for the return value of approve function in
PrioritizedOperatorSubtaskState#resolvePrioritizedAlternatives
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephenJeson/flink flink-9185
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5894.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5894
----
commit 80a9cf185dc33fe0182563e945635bc5ea971453
Author: Stephen Jason <stephendinf@...>
Date: 2018-04-21T11:19:26Z
[FLINK-9185] [runtime] Fix potential null dereference in
PrioritizedOperatorSubtaskState#resolvePrioritizedAlternatives
----
> Potential null dereference in
> PrioritizedOperatorSubtaskState#resolvePrioritizedAlternatives
> --------------------------------------------------------------------------------------------
>
> Key: FLINK-9185
> URL: https://issues.apache.org/jira/browse/FLINK-9185
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: mingleizhang
> Priority: Minor
>
> {code}
> if (alternative != null
> && alternative.hasState()
> && alternative.size() == 1
> && approveFun.apply(reference, alternative.iterator().next())) {
> {code}
> The return value from approveFun.apply would be unboxed.
> We should check that the return value is not null.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
