Github user yuqi1129 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5902#discussion_r183697720
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobVertexTaskManagersHandler.java
---
@@ -83,6 +90,24 @@ protected JobVertexTaskManagersInfo handleRequest(
throw new NotFoundException(String.format("JobVertex %s
not found", jobVertexID));
}
+ return createJobVertexTaskManagersInfo(jobVertex, jobID,
metricFetcher);
+ }
+
+ @Override
+ public Collection<ArchivedJson>
archiveJsonWithPath(AccessExecutionGraph graph) throws IOException {
+ Collection<? extends AccessExecutionJobVertex> vertices =
graph.getAllVertices().values();
+ List<ArchivedJson> archive = new ArrayList<>(vertices.size());
+ for (AccessExecutionJobVertex task : vertices) {
+ ResponseBody json =
createJobVertexTaskManagersInfo(task, graph.getJobID(), null);
+ String path =
getMessageHeaders().getTargetRestEndpointURL()
+ .replace(':' + JobIDPathParameter.KEY,
graph.getJobID().toString())
--- End diff --
```
':' + JobIDPathParameter.KEY
':' + JobVertexIdPathParameter.KEY
```
We can make them constant values
---
