Github user yuqi1129 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5902#discussion_r183702452
  
    --- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
 ---
    @@ -211,7 +215,7 @@ public void run() {
                                                }
                                        }
                                        if (updateOverview) {
    -                                           updateJobOverview(webDir);
    +                                           
updateJobOverview(webOverviewDir, webDir);
                                        }
    --- End diff --
    
    Could not figure out the function of `numFinishedPolls.countDown();`in line 
224, seems that `numFinishedPolls`   is useless as it was initialized 0


---

Reply via email to