Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/907#issuecomment-122389145
+1 for @chiwanpark's first point
I was actually also thinking about separating different join types for
performance. What could also help is to make the `outerJoinType` variable
`final`. That might help the JIT compiler. Since separating the classes would
mean 9 classes instead of 3, I would suggest to implement a micro-benchmark
(only for one of the three types) to check the performance implications.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
