Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/907#issuecomment-124270766
Very nice work! :+1: I had just a few minor style regards.
It would be nice if you could check the overhead of having all outer join
cases handled by the same class vs. having a dedicated class for LEFT, RIGHT,
and FULL OUTER.
I would also like to run a major regression benchmark to double-check that
the refactoring of the current sort-merge join didn't cause a performance
regression. I can take care of that once you addressed the comments.
If all lights are green after that, I would be happy to merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
