Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5889#discussion_r183965718
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java
---
@@ -86,4 +86,19 @@ protected AmazonKinesis createKinesisClient(Properties
configProps) {
assertEquals(10000, clientConfiguration.getSocketTimeout());
}
+ @Test
+ public void testClientConfigOverride() {
+
+ Properties configProps = new Properties();
+ configProps.setProperty(AWSConfigConstants.AWS_REGION,
"us-east-1");
+ configProps.setProperty(AWSUtil.AWS_CLIENT_CONFIG_PREFIX +
"socketTimeout", "9999");
--- End diff --
Would this usage also subsume other commonly seen settings, such as setting
the AWS crredentials?
Currently we have these explicitly defined keys in `AWSConfigConstants`,
for which we might be able to get rid of (because we have to maintain the set
of config keys ourselves, which is not nice and hard to meet with all the
functionalities that KCL provides).
If so, we might also want tests + update our documents for those.
---
