Github user tweise commented on a diff in the pull request:
https://github.com/apache/flink/pull/5889#discussion_r184220854
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@ -186,7 +186,10 @@ protected KinesisProxy(Properties configProps) {
* @return
*/
protected AmazonKinesis createKinesisClient(Properties configProps) {
- return AWSUtil.createKinesisClient(configProps, new
ClientConfigurationFactory().getConfig());
+
+ ClientConfiguration awsClientConfig = new
ClientConfigurationFactory().getConfig();
+ AWSUtil.setAwsClientConfigProperties(awsClientConfig,
configProps);
+ return AWSUtil.createKinesisClient(configProps,
awsClientConfig);
--- End diff --
Actually there does not seem to be any overlap.
`AWSConfigConstants.AWS_REGION` and `AWSConfigConstants.AWS_ENDPOINT` are used
to construct the client, not the client config.
---
