Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5885#discussion_r184087107
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/AbstractHeapState.java
 ---
    @@ -42,33 +42,35 @@
        /** Map containing the actual key/value pairs. */
        protected final StateTable<K, N, SV> stateTable;
     
    -   /** This holds the name of the state and can create an initial default 
value for the state. */
    -   protected final SD stateDesc;
    -
        /** The current namespace, which the access methods will refer to. */
        protected N currentNamespace;
     
        protected final TypeSerializer<K> keySerializer;
     
    +   protected final TypeSerializer<SV> valueSerializer;
    +
        protected final TypeSerializer<N> namespaceSerializer;
     
    +   private final SV defaultValue;
    +
        /**
         * Creates a new key/value state for the given hash map of key/value 
pairs.
         *
    -    * @param stateDesc The state identifier for the state. This contains 
name
    -    *                           and can create a default state value.
    +    * @param valueSerializer The serializer for the state.
         * @param stateTable The state tab;e to use in this kev/value state. 
May contain initial state.
         */
        protected AbstractHeapState(
    -                   SD stateDesc,
                        StateTable<K, N, SV> stateTable,
                        TypeSerializer<K> keySerializer,
    -                   TypeSerializer<N> namespaceSerializer) {
    +                   TypeSerializer<SV> valueSerializer,
    +                   TypeSerializer<N> namespaceSerializer,
    --- End diff --
    
    Comments require update.


---

Reply via email to