Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5885#discussion_r184657398
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapFoldingState.java
 ---
    @@ -49,17 +49,18 @@
        /**
         * Creates a new key/value state for the given hash map of key/value 
pairs.
         *
    -    * @param stateDesc The state identifier for the state. This contains 
name
    -    *                           and can create a default state value.
    +    * @param valueSerializer The serializer for the state.
         * @param stateTable The state tab;e to use in this kev/value state. 
May contain initial state.
         */
        public HeapFoldingState(
    -                   FoldingStateDescriptor<T, ACC> stateDesc,
                        StateTable<K, N, ACC> stateTable,
                        TypeSerializer<K> keySerializer,
    -                   TypeSerializer<N> namespaceSerializer) {
    -           super(stateDesc, stateTable, keySerializer, 
namespaceSerializer);
    -           this.foldTransformation = new FoldTransformation<>(stateDesc);
    +                   TypeSerializer<ACC> valueSerializer,
    +                   TypeSerializer<N> namespaceSerializer,
    +                   ACC defaultValue,
    --- End diff --
    
    Javadocs for all state classes are now updated.


---

Reply via email to