Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5885#discussion_r184841123
  
    --- Diff: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBState.java
 ---
    @@ -190,4 +197,12 @@ protected void writeKeyWithGroupAndNamespace(
                RocksDBKeySerializationUtils.writeKey(key, keySerializer, 
keySerializationStream, keySerializationDataOutputView, ambiguousKeyPossible);
                RocksDBKeySerializationUtils.writeNameSpace(namespace, 
namespaceSerializer, keySerializationStream, keySerializationDataOutputView, 
ambiguousKeyPossible);
        }
    +
    +   protected V getDefaultValue() {
    --- End diff --
    
    Not too sure about this one.
    
    That would require introducing 2 methods in the `InternalKvState`:
    1. A getter method that returns the default value.
    2. A default method that actually does the serialization copying of the 
default value (the current `getDefaultValue` method).


---

Reply via email to