[GitHub] flink pull request #5885: [FLINK-8715] Remove usage of StateDescriptor in st...

[bowenli86]

Github user bowenli86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5885#discussion_r184831125
  
    --- Diff: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBState.java
 ---
    @@ -190,4 +197,12 @@ protected void writeKeyWithGroupAndNamespace(
                RocksDBKeySerializationUtils.writeKey(key, keySerializer, 
keySerializationStream, keySerializationDataOutputView, ambiguousKeyPossible);
                RocksDBKeySerializationUtils.writeNameSpace(namespace, 
namespaceSerializer, keySerializationStream, keySerializationDataOutputView, 
ambiguousKeyPossible);
        }
    +
    +   protected V getDefaultValue() {
    --- End diff --
    
    this method is duplicated among some impl classes. We can move it to 
`InternalKvState` as a [default 
method](https://docs.oracle.com/javase/tutorial/java/IandI/defaultmethods.html).


---