Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5901#discussion_r185448995
  
    --- Diff: 
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java 
---
    @@ -85,54 +88,75 @@ public void checkForProhibitedLogContents() {
        public void testDetachedMode() throws InterruptedException, IOException 
{
                LOG.info("Starting testDetachedMode()");
                addTestAppender(FlinkYarnSessionCli.class, Level.INFO);
    -           Runner runner =
    -                   startWithArgs(new String[]{"-j", 
flinkUberjar.getAbsolutePath(),
    -                                           "-t", 
flinkLibFolder.getAbsolutePath(),
    -                                           "-n", "1",
    -                                           "-jm", "768",
    -                                           "-tm", "1024",
    -                                           "--name", "MyCustomName", // 
test setting a custom name
    -                                           "--detached"},
    -                           "Flink JobManager is now running on", 
RunTypes.YARN_SESSION);
    -
    +           File exampleJarLocation = 
getTestJarPath("StreamingWordCount.jar");
    --- End diff --
    
    I think we shouldn't change the example we run as part of this PR. It's 
somewhat unrelated.


---

Reply via email to