[ 
https://issues.apache.org/jira/browse/FLINK-8237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463035#comment-16463035
 ] 

ASF GitHub Bot commented on FLINK-8237:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5927#discussion_r185932952
  
    --- Diff: 
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
 ---
    @@ -550,6 +550,9 @@ private void openNewPartFile(Path bucketPath, 
BucketState<T> bucketState) throws
                Path inProgressPath = getInProgressPathFor(partPath);
                if (bucketState.writer == null) {
                        bucketState.writer = writerTemplate.duplicate();
    +                   if (bucketState.writer == null) {
    +                           throw new RuntimeException("Could not duplicate 
writer.");
    --- End diff --
    
    I would add the class name of the `writerTemplate` object and that the 
class needs to implement the `Writer.duplicate()` method.


> BucketingSink throws NPE when Writer.duplicate returns null
> -----------------------------------------------------------
>
>                 Key: FLINK-8237
>                 URL: https://issues.apache.org/jira/browse/FLINK-8237
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Gábor Hermann
>            Priority: Minor
>
> Users need to look into Flink code to find the cause. We could catch that 
> null before even running the job.
> {code:java}
> java.lang.NullPointerException
>         at 
> org.apache.flink.streaming.connectors.fs.bucketing.BucketingSink.openNewPartFile(BucketingSink.java:546)
>         at 
> org.apache.flink.streaming.connectors.fs.bucketing.BucketingSink.invoke(BucketingSink.java:441)
>         at 
> org.apache.flink.streaming.api.operators.StreamSink.processElement(StreamSink.java:41)
>         at 
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:528)
>         at 
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:503)
>         at 
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:483)
>         at 
> org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:891)
>         at 
> org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:869)
>         at 
> org.apache.flink.streaming.api.operators.StreamFilter.processElement(StreamFilter.java:40)
>         at 
> org.apache.flink.streaming.runtime.io.StreamInputProcessor.processInput(StreamInputProcessor.java:206)
>         at 
> org.apache.flink.streaming.runtime.tasks.OneInputStreamTask.run(OneInputStreamTask.java:69)
>         at 
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:263)
>         at org.apache.flink.runtime.taskmanager.Task.run(Task.java:702)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to