[ 
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463760#comment-16463760
 ] 

ASF GitHub Bot commented on FLINK-8690:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5940#discussion_r186022377
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
 ---
    @@ -641,7 +641,8 @@ class AggregationCodeGenerator(
                    |      java.util.Map.Entry entry = (java.util.Map.Entry) 
mergeIt$i.next();
                    |      Object k = entry.getKey();
    --- End diff --
    
    Change this line to `${classOf[Row].getCanonicalName} k = 
(${classOf[Row].getCanonicalName}) entry.getKey();`


> Support distinct aggregation on group windowed streaming tables.
> ----------------------------------------------------------------
>
>                 Key: FLINK-8690
>                 URL: https://issues.apache.org/jira/browse/FLINK-8690
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>            Priority: Major
>
> Currently, *FlinkLogicalAggregate / FlinkLogicalWindowAggregate* does not 
> allow distinct aggregate.
> We are proposing to reuse distinct aggregate codegen work designed for 
> *FlinkLogicalOverAggregate*, to support unbounded distinct aggregation on 
> datastream as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to