[ 
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464039#comment-16464039
 ] 

ASF GitHub Bot commented on FLINK-8690:
---------------------------------------

Github user walterddr commented on the issue:

    https://github.com/apache/flink/pull/5940
  
    Thanks @suez1224 @fhueske for the comments. I will change them accordingly. 
    
    Yes I copied a lot of test cases from @haohui's PR for my own testing. I 
can definitely put it on top given the runtime support is already merged in 
#5555. Procedure-wise question: should I rebase his commit then add my change 
on top, then attached to this PR? I am not sure if there's a clever way to both 
preserve the discussion in this thread and rebase on top of his change.


> Support distinct aggregation on group windowed streaming tables.
> ----------------------------------------------------------------
>
>                 Key: FLINK-8690
>                 URL: https://issues.apache.org/jira/browse/FLINK-8690
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>            Priority: Major
>
> Currently, *FlinkLogicalAggregate / FlinkLogicalWindowAggregate* does not 
> allow distinct aggregate.
> We are proposing to reuse distinct aggregate codegen work designed for 
> *FlinkLogicalOverAggregate*, to support unbounded distinct aggregation on 
> datastream as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to