[ 
https://issues.apache.org/jira/browse/FLINK-9276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465687#comment-16465687
 ] 

ASF GitHub Bot commented on FLINK-9276:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5954#discussion_r186376326
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerTestBase.java
 ---
    @@ -296,7 +296,7 @@ public TaskManagerLocation addTaskManager(int 
numberSlots) {
                @Override
                public void releaseTaskManager(ResourceID resourceId) {
                        try {
    -                           slotPool.releaseTaskManager(resourceId).get();
    +                           slotPool.releaseTaskManager(resourceId, 
null).get();
    --- End diff --
    
    I would avoid null exceptions.


> Improve error message when TaskManager fails
> --------------------------------------------
>
>                 Key: FLINK-9276
>                 URL: https://issues.apache.org/jira/browse/FLINK-9276
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Stephan Ewen
>            Assignee: vinoyang
>            Priority: Critical
>
> When a TaskManager fails, we frequently get a message
> {code}
> org.apache.flink.util.FlinkException: Releasing TaskManager 
> container_1524853016208_0001_01_000102
> {code}
> This message is misleading in that it sounds like an intended operation, when 
> it really is a failure of a container that the {{ResourceManager}} reports to 
> the {{JobManager}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to